Skip to content

chore: fix C lint errors (issue #7554) #7568

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 6, 2025
Merged

chore: fix C lint errors (issue #7554) #7568

merged 3 commits into from
Jul 6, 2025

Conversation

GeoDaoyu
Copy link
Contributor

@GeoDaoyu GeoDaoyu commented Jul 6, 2025

Resolves #7554.

Description

What is the purpose of this pull request?

This pull request:

  • fix C lint errors

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Jul 6, 2025
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Jul 6, 2025 •
edited
Loading

Coverage Report

Package Statements Branches Functions Lines
ndarray/base/nonsingleton-dimensions $\color{green}111/111$
$\color{green}+100.00\%$ 		$\color{green}5/5$
$\color{green}+100.00\%$ 		$\color{green}1/1$
$\color{green}+100.00\%$ 		$\color{green}111/111$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

kgryte
kgryte requested changes Jul 6, 2025
View reviewed changes
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GeoDaoyu Can you also update the header file, as well, to match the updated signature? https://github.com/stdlib-js/stdlib/blob/develop/lib/node_modules/%40stdlib/ndarray/base/nonsingleton-dimensions/include/stdlib/ndarray/base/nonsingleton_dimensions.h

Thanks!

@kgryte kgryte added Needs Changes Pull request which needs changes before being merged. and removed Needs Review A pull request which needs code review. labels Jul 6, 2025
@GeoDaoyu
chore: fix C lint errors (issue stdlib-js#7554)
f23696a 
update signature in nonsingleton_dimensions.h

Signed-off-by: zhanggy <[email protected]>
@GeoDaoyu
Copy link
Contributor Author

GeoDaoyu commented Jul 6, 2025

do you mean this? I updated nonsingleton_dimensions.h

kgryte
kgryte approved these changes Jul 6, 2025
View reviewed changes
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks, @GeoDaoyu.

@kgryte kgryte removed the Needs Changes Pull request which needs changes before being merged. label Jul 6, 2025
@kgryte
Copy link
Member

kgryte commented Jul 6, 2025

do you mean this? I updated nonsingleton_dimensions.h

Yes, I meant the associated header. The signatures for the src file and the corresponding forward declaration in the header file should be the same. So if we make a change to one, we need to make a change to the other.

@kgryte kgryte merged commit 15fa50d into stdlib-js:develop Jul 6, 2025
10 checks passed
@GeoDaoyu
Copy link
Contributor Author

GeoDaoyu commented Jul 6, 2025

do you mean this? I updated nonsingleton_dimensions.h

Yes, I meant the associated header. The signatures for the src file and the corresponding forward declaration in the header file should be the same. So if we make a change to one, we need to make a change to the other.

OK, I see. Signature should be the same.

@GeoDaoyu GeoDaoyu deleted the fix/CLint7554 branch July 6, 2025 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kgryte kgryte kgryte approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix C lint errors
3 participants
@GeoDaoyu @stdlib-bot @kgryte